Skip to content

Comments

feat: add extra logs to DTL#439

Merged
annieke merged 8 commits intomasterfrom
feat/improved-dtl-logs
Apr 15, 2021
Merged

feat: add extra logs to DTL#439
annieke merged 8 commits intomasterfrom
feat/improved-dtl-logs

Conversation

@annieke
Copy link
Contributor

@annieke annieke commented Apr 13, 2021

Description
Adding extra logs to DTL to improve overall observability.

Additional context
DTL started with better logging than batch submitter, so most of these are on initialization and whenever we respond to API calls. Open to changing these to .debug instead!

Metadata
https://github.com/ethereum-optimism/roadmap/issues/860

@gakonst gakonst force-pushed the feat/improved-dtl-logs branch from 0608209 to d286f31 Compare April 13, 2021 07:36
@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2021

🦋 Changeset detected

Latest commit: 63bcaac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@eth-optimism/core-utils Patch
@eth-optimism/data-transport-layer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@annieke annieke requested review from snario and tynes April 14, 2021 00:07
@annieke annieke force-pushed the feat/improved-dtl-logs branch from 7b345d7 to e09f32e Compare April 15, 2021 03:15
@annieke annieke requested a review from snario April 15, 2021 03:16
@annieke annieke merged commit 01eaf2c into master Apr 15, 2021
@annieke annieke deleted the feat/improved-dtl-logs branch April 15, 2021 17:51
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
* feat: add extra logs to DTL

* chore: add changeset

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
emhane added a commit that referenced this pull request Feb 3, 2026
This PR consumes trie updates and hashed state directly from
notifications, falling back to full block execution when notification
data is missing.

There are known serialization/deserialization issues with the WAL.
Before starting the node, ensure the WAL is cleaned. The Proof History
ExEx is designed to tolerate missing notification data, but if you are
running any additional ExEx components, ensure they can also safely
handle gaps in notification data.

Due to the above limitation, the resyncing test has been disabled.

Closes #420
Based on op-rs/op-reth#425

---------

Co-authored-by: Brian Picciano <me@mediocregopher.com>
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants