Conversation
8dce4d5 to
adad213
Compare
|
|
@tynes what's the status of this? Is this a feature we want on master? Can imagine it'd generate a lot of redundant logs. |
|
Lets tag this as "Do not merge", this branch is useful for debugging the problems we have been seeing recently when We have determined that 2 instances of the We forked geth before the revert messages would be passed back through the RPC, see ethereum/go-ethereum#21083
This adds no additional loglines, just adds a single additional value to a logline that already exists Happy to close when we confirm with Synthetix that the bug is a user error |
adad213 to
9c42428
Compare
|
@K-Ho I have rebased and added an additional commit on top of this PR. It does 2 things: |
|
The transaction fees on L2 are currently overpriced on Kovan and underpriced on Mainnet. Maybe we do want the commits that add the updated logs? 2f6b0ec is now part of #519, so that will be removed from this branch when it gets rebased again This branch is continued to be used for debugging |
|
Going to close this because it hasn't been used in awhile |
Removes the TODO comments in the host server; The catch-all error handling here fits our usecase.
this returns an option because deposits are not signed.
Closes op-rs/op-reth#427 --------- Co-authored-by: itschaindev <jagrutk@protonmail.com>
Description
This PR will add the gas used into the logline for
eth_estimateGasso that we can see how much gas transactions are using