Skip to content

feat(ctb): add nicer log lines to dictator steps#4210

Merged
mergify[bot] merged 1 commit intodevelopfrom
sc/ctb-system-dictator-logs
Dec 5, 2022
Merged

feat(ctb): add nicer log lines to dictator steps#4210
mergify[bot] merged 1 commit intodevelopfrom
sc/ctb-system-dictator-logs

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Dec 5, 2022

Description
Significantly improves the SystemDictator step process by adding clear logs that describe what each step is doing.
A clear and concise description of the features you're adding in this pull request.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

⚠️ No Changeset found

Latest commit: 100f62d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@smartcontracts smartcontracts force-pushed the sc/ctb-system-dictator-logs branch from 0ea39b2 to c74f524 Compare December 5, 2022 19:00
@tynes
Copy link
Contributor

tynes commented Dec 5, 2022

Generally looks good to me, just waiting for the devnet with deployed contracts to pass in CI

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

Hey @smartcontracts, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.

@mergify mergify bot removed the on-merge-train label Dec 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Dec 5, 2022
Significantly improves the SystemDictator step process by adding clear
logs that describe what each step is doing.
@smartcontracts smartcontracts force-pushed the sc/ctb-system-dictator-logs branch from c74f524 to 100f62d Compare December 5, 2022 19:43
@mergify mergify bot removed the conflict label Dec 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #4210 (100f62d) into develop (f091242) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4210      +/-   ##
===========================================
- Coverage    42.88%   42.88%   -0.01%     
===========================================
  Files          319      319              
  Lines        17259    17259              
  Branches       776      776              
===========================================
- Hits          7402     7401       -1     
+ Misses        9349     9348       -1     
- Partials       508      510       +2     
Flag Coverage Δ
bedrock-go-tests 37.66% <ø> (-0.01%) ⬇️
contracts-bedrock-tests 38.16% <ø> (ø)
contracts-governance-tests 83.05% <ø> (ø)
contracts-periphery-tests 95.17% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 42.17% <ø> (ø)
sdk-tests 39.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/heartbeat/service.go 54.05% <0.00%> (-2.71%) ⬇️

mergify bot added a commit that referenced this pull request Dec 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify bot added a commit that referenced this pull request Dec 5, 2022
mergify bot added a commit that referenced this pull request Dec 5, 2022
mergify bot added a commit that referenced this pull request Dec 5, 2022
@mergify mergify bot merged commit 94b8845 into develop Dec 5, 2022
@mergify mergify bot deleted the sc/ctb-system-dictator-logs branch December 5, 2022 20:28
@mergify mergify bot removed the on-merge-train label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants