Skip to content

maint(ctb): minor comment cleanup#4204

Merged
mergify[bot] merged 1 commit intodevelopfrom
sc/ctb-comment-cleanup
Dec 5, 2022
Merged

maint(ctb): minor comment cleanup#4204
mergify[bot] merged 1 commit intodevelopfrom
sc/ctb-comment-cleanup

Conversation

@smartcontracts
Copy link
Contributor

Description
Cleans up a few minor issues with comments.
A clear and concise description of the features you're adding in this pull request.

Tests

Please describe any tests you've add

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

⚠️ No Changeset found

Latest commit: 056a9df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #4204 (056a9df) into develop (902985f) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4204      +/-   ##
===========================================
- Coverage    42.93%   42.86%   -0.07%     
===========================================
  Files          319      319              
  Lines        17255    17255              
  Branches       776      776              
===========================================
- Hits          7408     7396      -12     
- Misses        9340     9348       +8     
- Partials       507      511       +4     
Flag Coverage Δ
bedrock-go-tests 37.62% <ø> (-0.10%) ⬇️
contracts-bedrock-tests 38.38% <ø> (ø)
contracts-governance-tests 83.05% <ø> (ø)
contracts-periphery-tests 95.17% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 42.17% <ø> (ø)
sdk-tests 39.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontracts-bedrock/contracts/L1/L1StandardBridge.sol 100.00% <ø> (ø)
.../contracts-bedrock/contracts/L1/L2OutputOracle.sol 84.37% <ø> (ø)
...es/contracts-bedrock/contracts/L1/SystemConfig.sol 0.00% <ø> (ø)
...tracts-bedrock/contracts/L2/CrossDomainOwnable.sol 100.00% <ø> (ø)
...racts-bedrock/contracts/L2/CrossDomainOwnable2.sol 100.00% <ø> (ø)
...ontracts-bedrock/contracts/L2/L2StandardBridge.sol 81.81% <ø> (ø)
...cts-bedrock/contracts/universal/StandardBridge.sol 72.41% <ø> (ø)
op-node/p2p/discovery.go 67.01% <0.00%> (-3.10%) ⬇️
op-node/sources/batching.go 81.25% <0.00%> (-2.68%) ⬇️

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will approve after leaving comments, should auto merge once comments are addressed

Cleans up a few minor issues with comments.
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify bot added a commit that referenced this pull request Dec 5, 2022
@mergify mergify bot merged commit ee96ff8 into develop Dec 5, 2022
@mergify mergify bot deleted the sc/ctb-comment-cleanup branch December 5, 2022 20:29
@mergify mergify bot removed the on-merge-train label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants