Add additional l2oo sanity check

[mslipper]

Ensures that the L2OO starting timestamp is not <= 0. When -1 is used in migration configs, the negative value was being passed into the genesis block directly. This led to a wraparound, since we cast the timestamp to a uint64 elsewhere in the code.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8e93986

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mslipper]

Current dependencies on/for this PR:

• develop
  • PR Add additional l2oo sanity check #4193 👈

This comment was auto-generated by Graphite.

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.

[codecov-commenter]

Codecov Report

Merging #4193 (8e93986) into develop (e92de35) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4193      +/-   ##
===========================================
- Coverage    42.93%   42.84%   -0.10%     
===========================================
  Files          319      319              
  Lines        17251    17256       +5     
  Branches       776      776              
===========================================
- Hits          7407     7393      -14     
- Misses        9336     9351      +15     
- Partials       508      512       +4     

Flag	Coverage Δ
bedrock-go-tests	37.60% <0.00%> (-0.13%)	⬇️
contracts-bedrock-tests	38.38% <ø> (ø)
contracts-governance-tests	83.05% <ø> (ø)
contracts-periphery-tests	95.17% <ø> (ø)
contracts-tests	98.86% <ø> (ø)
core-utils-tests	60.41% <ø> (ø)
dtl-tests	47.15% <ø> (ø)
fault-detector-tests	42.17% <ø> (ø)
sdk-tests	39.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
op-chain-ops/genesis/db_migration.go	0.00% <0.00%> (ø)
op-node/heartbeat/service.go	54.05% <0.00%> (-10.82%)	⬇️
op-node/sources/batching.go	81.25% <0.00%> (-2.68%)	⬇️
op-node/p2p/discovery.go	65.97% <0.00%> (-2.41%)	⬇️