Skip to content

feat(ctb): MPT Fuzzing contract changes#4162

Closed
clabby wants to merge 1 commit intoclabby/ctb/merkle-trie-refactor/go-fuzzfrom
clabby/ctb/merkle-trie-refactor/contract-changes
Closed

feat(ctb): MPT Fuzzing contract changes#4162
clabby wants to merge 1 commit intoclabby/ctb/merkle-trie-refactor/go-fuzzfrom
clabby/ctb/merkle-trie-refactor/contract-changes

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Dec 2, 2022

Overview

Reopened version of #4008 - CircleCI didn't like the @ in the old branch name.

Do not merge until after #4125 - bedrock contract tests will not pass due to the new testFuzz naming convention change


Adds a fuzz test input generator for testing Bedrock's MerkleTrie.sol.

Go version of #3847

Tests

Adds fuzz tests for MerkleTrie:

  • testFuzz_get_validProofs_success
  • testFuzz_get_invalidRoot_reverts
  • testFuzz_get_extraProofElements_reverts
  • testFuzz_get_invalidLargeInternalHash_reverts
  • testFuzz_get_invalidInternalNodeHash_reverts
  • testFuzz_get_corruptedProof_reverts
  • testFuzz_get_invalidDataRemainder_reverts
  • testFuzz_get_prefixedValidKey_reverts
  • testFuzz_get_emptyKey_reverts
  • testFuzz_get_partialProof_reverts

Metadata
ENG-3048

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2022

⚠️ No Changeset found

Latest commit: 939ec85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@clabby
Copy link
Contributor Author

clabby commented Dec 2, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@clabby clabby force-pushed the clabby/ctb/merkle-trie-refactor/contract-changes branch from 4d25279 to 5702fc5 Compare December 2, 2022 00:42
@trianglesphere trianglesphere self-requested a review December 2, 2022 19:24
@clabby clabby closed this Dec 5, 2022
@clabby clabby reopened this Dec 6, 2022
@clabby clabby force-pushed the clabby/ctb/merkle-trie-refactor/go-fuzz branch from 857cb3d to 69d2346 Compare December 6, 2022 02:45
@clabby clabby force-pushed the clabby/ctb/merkle-trie-refactor/contract-changes branch 2 times, most recently from 977f35b to 939ec85 Compare December 6, 2022 02:54
@clabby clabby closed this Dec 6, 2022
@clabby clabby deleted the clabby/ctb/merkle-trie-refactor/contract-changes branch December 8, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants