merge-queue: embarking develop (c975c96), #4135, #4132 and #4056 together#4152
Closed
mergify[bot] wants to merge 11 commits intodevelopfrom
Closed
merge-queue: embarking develop (c975c96), #4135, #4132 and #4056 together#4152mergify[bot] wants to merge 11 commits intodevelopfrom
mergify[bot] wants to merge 11 commits intodevelopfrom
Conversation
Adds message versioning to the L2ToL1MessagePasser, using the same scheme as in the CrossDomainMessenger. Also renames the "nonce" variable to "messageNonce" in line with the naming within the CrossDomainMessenger contracts.
|
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| return *new(uint16), err | ||
| } | ||
|
|
||
| out0 := *abi.ConvertType(out[0], new(uint16)).(*uint16) |
Contributor
There was a problem hiding this comment.
Unchecked type assertion. (Line 215)
Created by unchecked-type-assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull request #4135 which was ahead in the queue has been dequeued. The pull request #4056 has been re-embarked. ✨
Branch develop (c975c96), #4135, #4132 and #4056 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #4056.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:check-neutral=ci/circleci: message-relayer-testscheck-skipped=ci/circleci: message-relayer-testscheck-success=ci/circleci: message-relayer-testscheck-neutral=ci/circleci: bss-core-testscheck-skipped=ci/circleci: bss-core-testscheck-success=ci/circleci: bss-core-testscheck-neutral=ci/circleci: contracts-testscheck-skipped=ci/circleci: contracts-testscheck-success=ci/circleci: contracts-testscheck-neutral=ci/circleci: core-utils-testscheck-skipped=ci/circleci: core-utils-testscheck-success=ci/circleci: core-utils-testscheck-neutral=ci/circleci: dtl-testscheck-skipped=ci/circleci: dtl-testscheck-success=ci/circleci: dtl-testscheck-neutral=ci/circleci: depcheckcheck-skipped=ci/circleci: depcheckcheck-success=ci/circleci: depcheckcheck-neutral=ci/circleci: geth-testscheck-skipped=ci/circleci: geth-testscheck-success=ci/circleci: geth-testscheck-neutral=ci/circleci: indexer-testscheck-skipped=ci/circleci: indexer-testscheck-success=ci/circleci: indexer-testscheck-neutral=ci/circleci: proxyd-testscheck-skipped=ci/circleci: proxyd-testscheck-success=ci/circleci: proxyd-testscheck-neutral=ci/circleci: replica-healthcheck-testscheck-skipped=ci/circleci: replica-healthcheck-testscheck-success=ci/circleci: replica-healthcheck-testscheck-neutral=ci/circleci: yarn-monorepocheck-skipped=ci/circleci: yarn-monorepocheck-success=ci/circleci: yarn-monorepocheck-neutral=ci/circleci: contracts-bedrock-testscheck-skipped=ci/circleci: contracts-bedrock-testscheck-success=ci/circleci: contracts-bedrock-testscheck-neutral=ci/circleci: contracts-governance-testscheck-skipped=ci/circleci: contracts-governance-testscheck-success=ci/circleci: contracts-governance-testscheck-neutral=ci/circleci: contracts-periphery-testscheck-skipped=ci/circleci: contracts-periphery-testscheck-success=ci/circleci: contracts-periphery-testscheck-neutral=ci/circleci: op-bindings-buildcheck-skipped=ci/circleci: op-bindings-buildcheck-success=ci/circleci: op-bindings-buildcheck-neutral=ci/circleci: bedrock-go-testscheck-skipped=ci/circleci: bedrock-go-testscheck-success=ci/circleci: bedrock-go-tests#approved-reviews-by>=1[🛡 GitHub branch protection]withdrawalsspec #4056#changes-requested-reviews-by=0[🛡 GitHub branch protection]withdrawalsspec #4056#review-threads-unresolved=0[🛡 GitHub branch protection]withdrawalsspec #4056branch-protection-review-decision=APPROVED[🛡 GitHub branch protection]withdrawalsspec #4056check-success=pr-labelercheck-neutral=pr-labelercheck-skipped=pr-labelercheck-success=ci/circleci: batch-submitter-testscheck-neutral=ci/circleci: batch-submitter-testscheck-skipped=ci/circleci: batch-submitter-testscheck-success=ci/circleci: gas-oracle-testscheck-neutral=ci/circleci: gas-oracle-testscheck-skipped=ci/circleci: gas-oracle-testscheck-success=ci/circleci: integration-testscheck-neutral=ci/circleci: integration-testscheck-skipped=ci/circleci: integration-testscheck-success=ci/circleci: devnet (with genesis contracts)check-neutral=ci/circleci: devnet (with genesis contracts)check-skipped=ci/circleci: devnet (with genesis contracts)check-success=ci/circleci: op-batcher-docker-buildcheck-neutral=ci/circleci: op-batcher-docker-buildcheck-skipped=ci/circleci: op-batcher-docker-buildcheck-success=ci/circleci: op-node-docker-buildcheck-neutral=ci/circleci: op-node-docker-buildcheck-skipped=ci/circleci: op-node-docker-buildcheck-success=ci/circleci: op-proposer-docker-buildcheck-neutral=ci/circleci: op-proposer-docker-buildcheck-skipped=ci/circleci: op-proposer-docker-buildcheck-success=ci/circleci: devnet (with deployed contracts)check-neutral=ci/circleci: devnet (with deployed contracts)check-skipped=ci/circleci: devnet (with deployed contracts)check-success=security/snyk (Optimism)check-neutral=security/snyk (Optimism)check-skipped=security/snyk (Optimism)More informations about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com