Closed
Conversation
Small refactor that has MerkleTrie.get throw explicitly when an element does not exist, rather than returning a non-existence boolean. Makes the code much cleaner. We need to review this change very carefully.
Gas snapshot
More negative cases
erc20 binding
clabby
requested review from
maurelian,
mslipper,
smartcontracts,
tynes and
zhwrd
as code owners
🦋 Changeset detectedLatest commit: 9e0b5d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Can you split this into two pieces - the fuzzer itself, then the test implementations? Graphite should have some tools to help you with that. |
clabby
force-pushed
the
clabby/ctb/merkle-trie-fuzz
branch
from
ad2642b to
9e0b5d3
Compare
Contributor
Author
Transferred to #4161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reopened version of #4008 - CircleCI didn't like the
@in the old branch name.Do not merge until after #4125 - bedrock contract tests will not pass due to the new
testFuzznaming convention changeAdds a fuzz test input generator for testing Bedrock's
MerkleTrie.sol.Go version of #3847
Tests
Adds fuzz tests for
MerkleTrie:testFuzz_get_validProofs_successtestFuzz_get_invalidRoot_revertstestFuzz_get_extraProofElements_revertstestFuzz_get_invalidLargeInternalHash_revertstestFuzz_get_invalidInternalNodeHash_revertstestFuzz_get_corruptedProof_revertstestFuzz_get_invalidDataRemainder_revertstestFuzz_get_prefixedValidKey_revertstestFuzz_get_emptyKey_revertstestFuzz_get_partialProof_revertsMetadata
Linear: ENG-3048