Merged
Conversation
|
trianglesphere
changed the base branch from
develop
to
jg/use_circle_parallel
trianglesphere
force-pushed
the
jg/fix_lints
branch
from
611b822 to
91942cd
Compare
trianglesphere
force-pushed
the
jg/fix_lints
branch
from
566d6e2 to
c21b320
Compare
trianglesphere
force-pushed
the
jg/fix_lints
branch
from
c21b320 to
ffdbcbc
Compare
tynes
approved these changes
Nov 9, 2022
mslipper
approved these changes
Nov 10, 2022
95 tasks
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This uses the same set of lint options in CI as locally. Because these lints were not being
checked I had to fix several of them.