ci: Split go-bedrock tests & use circle CI parallelism for op-e2e#3931
Merged
mergify[bot] merged 5 commits intodevelopfrom Nov 9, 2022
Merged
ci: Split go-bedrock tests & use circle CI parallelism for op-e2e#3931mergify[bot] merged 5 commits intodevelopfrom
mergify[bot] merged 5 commits intodevelopfrom
Conversation
|
2e2d7c3 to
bd29c25
Compare
271b17e to
e8d728e
Compare
44b8780 to
e745a12
Compare
trianglesphere
commented
Nov 9, 2022
e745a12 to
ef8c796
Compare
protolambda
reviewed
Nov 9, 2022
protolambda
approved these changes
Nov 9, 2022
Adding OP_E2E_DISABLE_PARALLEL=true will stop the tests from using go's built in parallel helper. By default the tests will use go's parallel helper.
ef8c796 to
69b6e79
Compare
mslipper
approved these changes
Nov 9, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This first splits up the go-bedrock job into smaller more discrete jobs to ensure that we are using the same linters & test runner options for all packages. This also improves performance by parallelizing trivially paralleliziable jobs.
The second big change is to use
circlci tests splitto enable parallelism in CI instead of usingt.Parallel. It is configured with an env var so tests will remain fast with local development, but we cannot uset.Parallelin CI becausegotestsumcurrently does not do a good job of reporting the specific test that failed (because of the interleaved output) and instead reports multiple tests as failing when there is only one that failed. This improves the experience of using CI and debugging failed tests.The last change is to add and option to disable colored logs in the testlogger. Somewhere in the reporting pipeline the color escape codes are getting mangled & the logs are significantly harder to read because of the colors.
To retain compatibility with github required checks, all of the new go jobs feed into
bedrock-go-testswhich will simply return true if all of it's required jobs succeed.Metadata