Skip to content

op-bindings: Canonicalize storage types too#3930

Merged
mslipper merged 1 commit intodevelopfrom
feat/remap-storage
Nov 8, 2022
Merged

op-bindings: Canonicalize storage types too#3930
mslipper merged 1 commit intodevelopfrom
feat/remap-storage

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

@mslipper mslipper commented Nov 8, 2022

Description

A clear and concise description of the features you're adding in this pull request.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 8, 2022

⚠️ No Changeset found

Latest commit: 198d377

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper mslipper requested a review from tynes November 8, 2022 21:40
@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 8, 2022

Still has escaping but lgtm

        "label": "mapping(address =u003e struct Counters.Counter)",

@mslipper
Copy link
Copy Markdown
Contributor Author

mslipper commented Nov 8, 2022

Yeah we can fix escaping separately.

@mslipper mslipper merged commit 8ed14a8 into develop Nov 8, 2022
@mslipper mslipper deleted the feat/remap-storage branch November 8, 2022 21:49
@mslipper mslipper mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants