[op-node] Check that BlockNumber is non-nil in the receipt validation#3881
Merged
tynes merged 1 commit intoethereum-optimism:developfrom Nov 5, 2022
Merged
Conversation
|
tynes
approved these changes
Nov 4, 2022
trianglesphere
approved these changes
Nov 4, 2022
Contributor
|
Authorized the build, should be green in a minute. |
Contributor
|
This should be safe to merge |
protolambda
approved these changes
Nov 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We saw
op-nodepanic in an internal PoA testnet, I believe due to a reorg that happened during a deploy (having multiple PoA signers with the same key during the deploy). This caused some of the tx receipts returned from the L1 have anullblockNumbervalue, causing apanic: runtime error: invalid memory address or nil pointer dereferenceerror.Tests
There doesn't appear to be any existing tests for this logic, but happy to add some if I'm missing where those are.
Additional context
Stacktrace: