Skip to content

op-node: catch up L2 sequencing based on time, not L1 origins#3818

Merged
trianglesphere merged 1 commit intodevelopfrom
time-based-catchup
Nov 7, 2022
Merged

op-node: catch up L2 sequencing based on time, not L1 origins#3818
trianglesphere merged 1 commit intodevelopfrom
time-based-catchup

Conversation

@protolambda
Copy link
Copy Markdown
Contributor

Description

Make sure to produce a L2 chain up to and including the latest wall clock timestamp. The L1 origin that we adopt doesn't matter in the catchup logic. When producing the block, and older L1 origin can be selected based on the conf depth, but the L2 chain should still be produced.

Tests

Fix based on alpha-1 testnet syncing occurence. Can extend testing in e2e for this later.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 29, 2022

⚠️ No Changeset found

Latest commit: 46a7936

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 29, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 2, 2022

Any plan for this PR to be actually merged?

@protolambda
Copy link
Copy Markdown
Contributor Author

@tynes yes, this is an important fix, thank you for reminding me.

@protolambda protolambda marked this pull request as ready for review November 4, 2022 23:15
Copy link
Copy Markdown
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added a commit that referenced this pull request Nov 5, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2022

Hey @protolambda, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.

@mergify mergify bot removed the on-merge-train label Nov 5, 2022
@trianglesphere trianglesphere merged commit e8ed245 into develop Nov 7, 2022
@trianglesphere trianglesphere deleted the time-based-catchup branch November 7, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants