op-node: get block with sync status, make finalization more safe#3802
op-node: get block with sync status, make finalization more safe#3802mergify[bot] merged 4 commits intodevelopfrom
Conversation
|
|
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review. |
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
1afda72 to
7fc3e79
Compare
… finality delay with engine
7fc3e79 to
df1123f
Compare
|
bedrock go tests are failing. |
|
It's one unrelated action test that's failing, due to a bad nonce for a transaction. I think the pending-nonce retrieval in geth doesn't interact so well with fast modeled block building. Will re-run the test and see if it passes. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
This PR prepares the op-node derivation/driver bits for the op-proposer cleanup changes by securing the L2 finality better.
Changes:
CurrentL1Finalizedto sync status to identify the L1 block we do recognize for derivation, matching theCurrentL1field which is last used for deriving the safe part of the L2 chain.L1Finalizedin sync status just refers to the latest signal.Tests
Added an action test for L2 finalization edge cases, covering multiple batches and the edge case of a bad finality signal.
Metadata
Fix ENG-2772