Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
LGTM. A test to reproduce it would be nice to have (or an issue for future test, I think we can cover it with action-testing). And there's an unrelated change in the PR?
packages/contracts-bedrock/deploy/001-InitImplementations.deploy.ts
Outdated
Show resolved
Hide resolved
|
Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review. |
The batch queue was using the previous origin when computing if the origin was behind or not. It would then immediately advance it's internal origin to the next origin (confusingly coming from the `prev` stage). It would take action on the current origin based on out of date data. Specifically, it would not save an origin that should have been saved into the l1Blocks array. This causes errors because the L1 Origin of the safe head would not be present when attempting to derive the next batch after a reset.
trianglesphere
force-pushed
the
jg/bugfix
branch
from
edf3991 to
c5af4a5
Compare
github-actions
bot
removed
2-reviewers
A-pkg-contracts-bedrock
3 participants
Description
The batch queue was using the previous origin when computing if the origin was behind or not. It would then immediately advance it's internal origin to the next origin (confusingly coming from the
prevstage). It would take action on the current origin based on out of date data. Specifically, it would not save an origin that should have been saved into the l1Blocks array. This causes errors because the L1 Origin of the safe head would not be present when attempting to derive the next batch after a reset.Tests
Not tested either in a full reproduction or with unit tests.
Metadata