fix(proxyd): Fix compliance with JSON-RPC 2.0 spec by adding optional RPCError.Data#3683
Merged
mslipper merged 3 commits intoethereum-optimism:developfrom Oct 11, 2022
Conversation
🦋 Changeset detectedLatest commit: bb7502f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The JSON-RPC 2.0 specification indicates that the error object may contain an optional data field. Proxyd currently drops this field from any responses. This PR fixes that.
https://www.jsonrpc.org/specification#error_object
Tests
I added a test to check that if a data field is present in the response from a backend, it will be added to the response from proxyd. The existing test should validate that if data field is not present in the response from the backend, the data key should not be present in the JSON response from proxyd.