proxyd: Integrate custom rate limiter#3681
Merged
Conversation
🦋 Changeset detectedLatest commit: 01ae662 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
force-pushed
the
10-09-proxyd_Custom_rate_limiter_implementation
branch
from
ada9def to
f711c48
Compare
mslipper
force-pushed
the
10-09-proxyd_Integrate_custom_rate_limiter
branch
from
b90bb21 to
db4072d
Compare
Inphi
approved these changes
Oct 11, 2022
mslipper
force-pushed
the
10-09-proxyd_Integrate_custom_rate_limiter
branch
from
db4072d to
cf156ec
Compare
Integrates the custom rate limiter in the previous PR into the rest of the application. Also takes the opportunity to clean up how we instantiate Redis clients so that we can share them among multiple different services. There are some config changes in this PR. Specifically, you must specify a `base_rate` and `base_interval` in the rate limit config.
mslipper
force-pushed
the
10-09-proxyd_Custom_rate_limiter_implementation
branch
from
f711c48 to
c2b8efa
Compare
mslipper
force-pushed
the
10-09-proxyd_Integrate_custom_rate_limiter
branch
from
cf156ec to
01ae662
Compare
Base automatically changed from
10-09-proxyd_Custom_rate_limiter_implementation
to
develop
October 12, 2022 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates the custom rate limiter in the previous PR into the rest of the application. Also takes the opportunity to clean up how we instantiate Redis clients so that we can share them among multiple different services.
There are some config changes in this PR. Specifically, you must specify a
base_rateandbase_intervalin the rate limit config.