Skip to content

feat(ctb): introduces two step withdrawals#3677

Closed
smartcontracts wants to merge 1 commit intodevelopfrom
sc/ctb-two-step-withdraw
Closed

feat(ctb): introduces two step withdrawals#3677
smartcontracts wants to merge 1 commit intodevelopfrom
sc/ctb-two-step-withdraw

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Oct 9, 2022

Description
Introduces the concept of two step withdrawals for Bedrock. Two step withdrawals are a way to reduce the risk of withdrawals by forcing users to prove their withdrawal at the beginning of the challenge period. This reduces the risk of invalid withdrawal verification.

Tests
I have added tests for the new function and I have updated existing tests to work as well.

Additional context
Currently, this is a draft proposal for Bedrock and has not been confirmed for inclusion.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: b36946b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-sdk Area: packages/sdk labels Oct 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@smartcontracts
feat(ctb): introduces two step withdrawals
b36946b 
Introduces the concept of two step withdrawals for Bedrock. Two step
withdrawals are a way to reduce the risk of withdrawals by forcing users
to prove their withdrawal at the beginning of the challenge period. This
reduces the risk of invalid withdrawal verification.
@smartcontracts smartcontracts force-pushed the sc/ctb-two-step-withdraw branch from fb50021 to b36946b Compare October 9, 2022 02:56
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Oct 10, 2022
@mergify mergify bot added the sdk label Oct 19, 2022
@mergify mergify bot requested review from nickbalestra and roninjin10 October 19, 2022 22:20
@clabby clabby mentioned this pull request Nov 2, 2022
Merged
14 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 3, 2022
@github-actions github-actions bot closed this Nov 9, 2022
@mergify mergify bot removed the conflict label Nov 9, 2022
@smartcontracts smartcontracts deleted the sc/ctb-two-step-withdraw branch November 30, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickbalestra nickbalestra Awaiting requested review from nickbalestra

@roninjin10 roninjin10 Awaiting requested review from roninjin10

Assignees

No one assigned

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-sdk Area: packages/sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smartcontracts