Skip to content

indexer: Update DB package#3659

Merged
mslipper merged 1 commit intodevelopfrom
10-05-indexer_Update_DB_package
Oct 6, 2022
Merged

indexer: Update DB package#3659
mslipper merged 1 commit intodevelopfrom
10-05-indexer_Update_DB_package

Conversation

@mslipper
Copy link
Contributor

@mslipper mslipper commented Oct 5, 2022

Updates the indexer's DB package to support both Bedrock and the legacy system. 90% of of this is a revert back to Mark's last commit on the indexer pre-Bedrock.

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2022

⚠️ No Changeset found

Latest commit: d2180a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper
Copy link
Contributor Author

mslipper commented Oct 5, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@semgrep-app
Copy link
Contributor

semgrep-app bot commented Oct 5, 2022

Semgrep found 10 unchecked-type-assertion findings:

Unchecked type assertion.

Created by unchecked-type-assertion.

@tynes
Copy link
Contributor

tynes commented Oct 5, 2022

Is the plan to test this using the op-e2e utils once we get more stuff cleaned up?

There are currently linting errors, will review again once fixed

@mslipper
Copy link
Contributor Author

mslipper commented Oct 5, 2022

Correct, the last PR in the chain will have op-e2e tests. I’ll fix the linter.

Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming checks pass

@roninjin10 roninjin10 force-pushed the 10-05-indexer_Restore_some_bindings branch from 8470ebe to 197ceb1 Compare October 5, 2022 21:52
@tynes
Copy link
Contributor

tynes commented Oct 5, 2022

Correct, the last PR in the chain will have op-e2e tests. I’ll fix the linter.

I'm realizing there isn't a good way to include legacy contracts in op-e2e, is this something you would like to do?

@mslipper mslipper force-pushed the 10-05-indexer_Restore_some_bindings branch from 197ceb1 to 1d0516c Compare October 5, 2022 23:18
@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

Hey @mslipper! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Oct 5, 2022
@mslipper mslipper force-pushed the 10-05-indexer_Update_DB_package branch from bb3c79b to 5127b51 Compare October 6, 2022 15:25
@mergify mergify bot removed the conflict label Oct 6, 2022
@mslipper
Copy link
Contributor Author

mslipper commented Oct 6, 2022

I'm realizing there isn't a good way to include legacy contracts in op-e2e, is this something you would like to do?

I don't think we need to - they're already in bindings, and I can use a real network to test legacy support for the indexer.

@mslipper mslipper force-pushed the 10-05-indexer_Update_DB_package branch from 5127b51 to d2180a2 Compare October 6, 2022 15:27
Base automatically changed from 10-05-indexer_Restore_some_bindings to develop October 6, 2022 15:35
@mslipper mslipper requested a review from tynes October 6, 2022 15:40
@mslipper mslipper merged commit 7e0450b into develop Oct 6, 2022
@mslipper mslipper deleted the 10-05-indexer_Update_DB_package branch October 6, 2022 19:02
@mslipper mslipper mentioned this pull request Oct 13, 2022
@mslipper mslipper mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants