ctb: Rename event in the L2ToL1MessagePasser#3652
Merged
mergify[bot] merged 5 commits intodevelopfrom Oct 5, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 47d1620 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
maurelian
force-pushed
the
ctb/rename-event
branch
from
7382504 to
56af4da
Compare
The new name MessagePassed, is less confusing since the name 'WithdrawalInitiated' is used in the L2 Bridge.
Contributor
|
Going to need to deeply grep to get all of the changes required for this one |
maurelian
force-pushed
the
ctb/rename-event
branch
from
56af4da to
8373e37
Compare
smartcontracts
approved these changes
Oct 5, 2022
maurelian
commented
Oct 5, 2022
tynes
approved these changes
Oct 5, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nitaliano
pushed a commit
that referenced
this pull request
May 20, 2024
* ctb: Rename event in the L2ToL1MessagePasser The new name MessagePassed, is less confusing since the name 'WithdrawalInitiated' is used in the L2 Bridge. * Chore: bindings * op-node: fix tests for MessagePassed topic 0 * chore: Changeset Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new name MessagePassed, is less confusing since the
name 'WithdrawalInitiated' is used in the L2 Bridge.
Tests
Existing tests are updated to match the implementation.