Install a specific slither commit#3651
Merged
mergify[bot] merged 1 commit intodevelopfrom Oct 4, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 3bd0527 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
maurelian
force-pushed
the
slither-version
branch
from
59775f9 to
8e4cae8
Compare
github-actions
bot
removed
the
A-pkg-contracts-bedrock
maurelian
force-pushed
the
slither-version
branch
from
8e4cae8 to
1414989
Compare
--wip-- wip
maurelian
force-pushed
the
slither-version
branch
from
1414989 to
3bd0527
Compare
zhwrd
approved these changes
Oct 4, 2022
tynes
approved these changes
Oct 4, 2022
Contributor
tynes
left a comment
tynes
left a comment
There was a problem hiding this comment.
Generally looks good to me, will need to trigger a release after merge
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the CI builder to install slither from a specific commit, which will allow us to run it on our code without having to remove the forge test files.
Tests
I tested the build locally.