op-node: split driver state/model into L1 state, L1 origin selector, L2 sequencer, L2 derivation#3647
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
trianglesphere
left a comment
There was a problem hiding this comment.
The biggest thing is that I don't think we're ready to migrate over to the start/complete block building process, but it is good that we're setting it up to go that way.
|
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review. |
|
Will rebase to fix merge conflicts, and include the deadlock fix |
02429ef to
fb7578e
Compare
trianglesphere
left a comment
There was a problem hiding this comment.
nice work, every looks great
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
TLDR of driver refactor design doc:
Drivershould not mix state with event handling so much. Separate with interfaces for testing instead.Changes:
Driver struct { state }that proxies all calls. We just define aDriverstruct.StartfunctionTests
No functionality changed, it's rewiring to make testing much more viable. In the L2 sequencer action-testing PR I plan to plug in all these state components (origin selection, l1 state, sequencing). We can wait with this PR if we're unsure.
Metadata
Fix ENG-2864