Skip to content

op-node: Remove BlockIDRange#3640

Merged
mergify[bot] merged 2 commits intodevelopfrom
jg/remove_block_range
Oct 4, 2022
Merged

op-node: Remove BlockIDRange#3640
mergify[bot] merged 2 commits intodevelopfrom
jg/remove_block_range

Conversation

@trianglesphere
Copy link
Contributor

Description

This function was not being used and could be safely removed.

This function was not being used and could be safely removed.
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

⚠️ No Changeset found

Latest commit: 00e6d51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@tynes
Copy link
Contributor

tynes commented Oct 3, 2022

Perhaps the hive test failure is a flake?

@trianglesphere
Copy link
Contributor Author

Perhaps the hive test failure is a flake?

I think so. Currently re-running. It didn't fail at build time.

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, forgot we kept this around, indeed dead code.

@trianglesphere trianglesphere requested a review from tynes October 3, 2022 23:43
@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 0eaae3b into develop Oct 4, 2022
@mergify mergify bot deleted the jg/remove_block_range branch October 4, 2022 01:19
@mergify mergify bot removed the on-merge-train label Oct 4, 2022
This was referenced Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants