Skip to content

sdk: add hh task for finalizing withdrawal#3638

Merged
mergify[bot] merged 3 commits intodevelopfrom
feat/hh-task-finalize-withdrawal
Oct 4, 2022
Merged

sdk: add hh task for finalizing withdrawal#3638
mergify[bot] merged 3 commits intodevelopfrom
feat/hh-task-finalize-withdrawal

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Oct 3, 2022

Description

Now we no longer need to use one off scripts for testing this kind of thing. The hh task will check to see the status of a transaction hash and then finalize the withdrawal on L1 if the message status is ready for relay. It does this by creating a CrossChainMessenger.

@tynes
sdk: add hh task for finalizing withdrawal
75d4f2e 
Now we no longer need to use one off scripts for testing this kind
of thing. The hh task will check to see the status of a transaction
hash and then finalize the withdrawal on L1 if the message status
is ready for relay. It does this by creating a `CrossChainMessenger`.
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 63c03f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes tynes requested a review from smartcontracts October 3, 2022 18:26
@github-actions github-actions bot added the A-pkg-sdk Area: packages/sdk label Oct 3, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@tynes tynes requested a review from maurelian October 3, 2022 18:27
maurelian
maurelian reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question for now.

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot removed the on-merge-train label Oct 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit f39853e into develop Oct 4, 2022
@mergify mergify bot deleted the feat/hh-task-finalize-withdrawal branch October 4, 2022 01:38
@mergify mergify bot removed the on-merge-train label Oct 4, 2022
This was referenced Oct 13, 2022
Merged
Merged
nitaliano pushed a commit that referenced this pull request May 20, 2024
@tynes @mergify
sdk: add hh task for finalizing withdrawal (#3638)
fbb3b59 
Now we no longer need to use one off scripts for testing this kind
of thing. The hh task will check to see the status of a transaction
hash and then finalize the withdrawal on L1 if the message status
is ready for relay. It does this by creating a `CrossChainMessenger`.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maurelian maurelian maurelian approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

+1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-pkg-sdk Area: packages/sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @mslipper @maurelian