Skip to content

ci: Parallelize op-e2e#3635

Merged
mslipper merged 4 commits intodevelopfrom
feat/t-parallel-op-e2e
Oct 3, 2022
Merged

ci: Parallelize op-e2e#3635
mslipper merged 4 commits intodevelopfrom
feat/t-parallel-op-e2e

Conversation

@mslipper
Copy link
Contributor

@mslipper mslipper commented Oct 3, 2022

Replaces my previous PRs since t.Parallel() works fine. Also exposes the listener on the op-node, so that we can use a port of zero and allow the kernel to allocate a port.

Replaces my previous PRs since `t.Parallel()` works fine. Also exposes the listener on the op-node, so that we can use a port of zero and allow the kernel to allocate a port.
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

⚠️ No Changeset found

Latest commit: 57d361a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@protolambda
Copy link
Contributor

The L2 engine actor may also need to be closed (my bad for not thinking of that in original PR)

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, but wondering about CLI flags, expected -parallel.

@mslipper mslipper merged commit bead5e1 into develop Oct 3, 2022
@mslipper mslipper deleted the feat/t-parallel-op-e2e branch October 3, 2022 17:06
This was referenced Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants