op-node: Integrate PollingClient with op-node#3630
Merged
trianglesphere merged 1 commit intodevelopfrom Oct 3, 2022
Merged
Conversation
|
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
force-pushed
the
10-01-op-node_Add_HTTP_wrapper_for_EthSubscribe
branch
from
3afabc6 to
0ce0c04
Compare
Contributor
|
Hey @mslipper! This PR has merge conflicts. Please fix them before continuing review. |
mslipper
force-pushed
the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
from
ed881c5 to
877511c
Compare
mslipper
force-pushed
the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
3 times, most recently
from
8fec312 to
08b43c1
Compare
mslipper
force-pushed
the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
from
08b43c1 to
9f97877
Compare
protolambda
approved these changes
Oct 3, 2022
Contributor
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
LGTM. Lmk if I need to re-review, the base PR may still see some changes.
mslipper
force-pushed
the
10-01-op-node_Add_HTTP_wrapper_for_EthSubscribe
branch
from
0ce0c04 to
d0c1219
Compare
mslipper
force-pushed
the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
from
9f97877 to
ea6a36c
Compare
mslipper
force-pushed
the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
from
ea6a36c to
fa3c51f
Compare
mslipper
force-pushed
the
10-01-op-node_Add_HTTP_wrapper_for_EthSubscribe
branch
from
d0c1219 to
ace8b36
Compare
mslipper
force-pushed
the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
from
fa3c51f to
b12c34b
Compare
trianglesphere
approved these changes
Oct 3, 2022
mslipper
force-pushed
the
10-01-op-node_Add_HTTP_wrapper_for_EthSubscribe
branch
from
ace8b36 to
492a1cd
Compare
mslipper
force-pushed
the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
4 times, most recently
from
2a0627f to
c66be9c
Compare
Contributor
|
Graphite Merge Job Current status: ✅ Merged This pull request was successfully merged as part of a stack. This comment was auto-generated by Graphite. Job Reference: djnQcRhFGqf86aZ5mLsM |
Base automatically changed from
10-01-op-node_Add_HTTP_wrapper_for_EthSubscribe
to
develop
October 3, 2022 19:48
Contributor
|
Hey @mslipper! This PR has merge conflicts. Please fix them before continuing review. |
Integrates the HTTP PollingClient with the op-node. To do this, I needed to change the RPC interface to return an `ethereum.Subscription` object rather than a concrete *rpc.ClientSubscription instance. I also introduced a new method to return the correct `client.RPC` implementation based on the user's chosen RPC URL. Lastly, I added an additional CircleCI job to run all end-to-end tests against an HTTP-based RPC endpoint to prevent issues from arising in the future.
trianglesphere
force-pushed
the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
from
c66be9c to
fec43a7
Compare
trianglesphere
deleted the
10-01-op-node_Integrate_PollingClient_with_op-node
branch
mslipper
added a commit
that referenced
this pull request
Oct 11, 2022
Integrates the HTTP PollingClient with the op-node. To do this, I needed to change the RPC interface to return an `ethereum.Subscription` object rather than a concrete *rpc.ClientSubscription instance. I also introduced a new method to return the correct `client.RPC` implementation based on the user's chosen RPC URL. Lastly, I added an additional CircleCI job to run all end-to-end tests against an HTTP-based RPC endpoint to prevent issues from arising in the future.
This was referenced Oct 11, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates the HTTP PollingClient with the op-node. To do this, I needed to change the RPC interface to return an
ethereum.Subscriptionobject rather than a concrete *rpc.ClientSubscription instance. I also introduced a new method to return the correctclient.RPCimplementation based on the user's chosen RPC URL.Lastly, I added an additional CircleCI job to run all end-to-end tests against an HTTP-based RPC endpoint to prevent issues from arising in the future.