Skip to content

op-node: Fully remove the progress API#3623

Merged
mergify[bot] merged 3 commits intodevelopfrom
jg/pipeline_cleanup_stage_2
Oct 4, 2022
Merged

op-node: Fully remove the progress API#3623
mergify[bot] merged 3 commits intodevelopfrom
jg/pipeline_cleanup_stage_2

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Sep 29, 2022 •
edited
Loading

It has been partially replaced with the Origin API, but the open/closed distinction no longer exists. At this point the there is still complexity around state management, but it is in a much better state to be handled.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: afd7c6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@trianglesphere trianglesphere mentioned this pull request Sep 29, 2022
Closed
@trianglesphere trianglesphere force-pushed the jg/pipeline_cleanup_stage_1 branch from 3bd03fc to 21c7758 Compare September 30, 2022 22:48
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2022

Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 30, 2022
@trianglesphere trianglesphere force-pushed the jg/pipeline_cleanup_stage_2 branch from 9d0f0fb to 3ab2a01 Compare September 30, 2022 22:49
@mergify mergify bot removed the conflict label Sep 30, 2022
@trianglesphere trianglesphere force-pushed the jg/pipeline_cleanup_stage_1 branch from 21c7758 to fea863e Compare October 3, 2022 19:56
@trianglesphere trianglesphere force-pushed the jg/pipeline_cleanup_stage_2 branch from 3ab2a01 to ad5f588 Compare October 3, 2022 19:56
@trianglesphere trianglesphere changed the base branch from jg/pipeline_cleanup_stage_1 to develop October 3, 2022 19:58
@trianglesphere trianglesphere force-pushed the jg/pipeline_cleanup_stage_2 branch from ad5f588 to f938c79 Compare October 3, 2022 20:00
@trianglesphere
op-node: Clean up pipeline
2c0ec21 
Now that the engine queue is the only step stage, it is easy to
consolidate different loops inside the derivation pipeline.
@trianglesphere
op-node: Fully remove the progress API
98c1856 
It has been partially replaced with the Origin API, but the open/closed
distinction no longer exists.
@trianglesphere trianglesphere force-pushed the jg/pipeline_cleanup_stage_2 branch from f938c79 to 98c1856 Compare October 3, 2022 20:57
@trianglesphere trianglesphere marked this pull request as ready for review October 3, 2022 20:57
protolambda
protolambda approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 46202cd into develop Oct 4, 2022
@mergify mergify bot deleted the jg/pipeline_cleanup_stage_2 branch October 4, 2022 04:11
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Oct 4, 2022
This was referenced Oct 13, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

+1 more reviewer

@protolambda protolambda protolambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trianglesphere @tynes @protolambda @mslipper