contracts-periphery: erc721 factory fixes#3615
Merged
mergify[bot] merged 3 commits intodevelopfrom Sep 29, 2022
Merged
Conversation
These changes make the `OptimismMintableERC721Factory` in line with the bedrock version of the `OptimismMintableERC20Factory`. We might as well follow what we are doing with the new erc20 factory to keep things in line with each other. These changes are very small, they just rename a function to not follow the deprecated naming scheme, the function now returns an address which makes testing/integration a bit easier and also does a slight refactor to prevent the need to cast a type 3 times.
🦋 Changeset detectedLatest commit: 9685cfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-op-bindings
sam-goldman
approved these changes
Sep 29, 2022
maurelian
reviewed
Sep 29, 2022
packages/contracts-periphery/contracts/universal/op-erc721/OptimismMintableERC721Factory.sol
Show resolved
Hide resolved
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
smartcontracts
approved these changes
Sep 29, 2022
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes make the
OptimismMintableERC721Factoryin line with the bedrock version of theOptimismMintableERC20Factory. We might as well follow what we are doing with the new erc20 factory to keep things in line with each other.These changes are very small, they just rename a function to not follow the deprecated naming scheme, the function now returns an address which makes testing/integration a bit easier and also does a slight refactor to prevent the need to cast a type 3 times.