Skip to content

Changsets: nag on .sol but not t.sol files#3614

Merged
maurelian merged 3 commits intodevelopfrom
ci/no-test-nag
Sep 29, 2022
Merged

Changsets: nag on .sol but not t.sol files#3614
maurelian merged 3 commits intodevelopfrom
ci/no-test-nag

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Sep 29, 2022

Description

Changes Mergify's changeset behavior to:

  1. nag when a .sol file is changed (it seems this was missing until now?)
  2. not nag when a .t.sol file is changed

I tested the changes here:

  • before (note that the h.sol file is not matched).
  • after

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

⚠️ No Changeset found

Latest commit: c16d9ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers C-protocol-critical Category: Modifies protocol-critical code labels Sep 29, 2022
@mergify mergify bot requested a review from smartcontracts September 29, 2022 15:32
@github-actions github-actions bot removed M-contracts C-protocol-critical Category: Modifies protocol-critical code labels Sep 29, 2022
@maurelian maurelian force-pushed the ci/no-test-nag branch 2 times, most recently from ae61dee to fbf7a26 Compare September 29, 2022 15:54
@maurelian maurelian changed the title ci: Don't nag on t.sol files Changsets: nag on .sol but not t.sol files Sep 29, 2022
@maurelian maurelian marked this pull request as ready for review September 29, 2022 15:59
@maurelian maurelian requested a review from mslipper September 29, 2022 15:59
@maurelian maurelian removed the request for review from smartcontracts September 29, 2022 16:28
@maurelian
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

refresh

✅ Pull request refreshed

@maurelian maurelian merged commit 6713581 into develop Sep 29, 2022
@maurelian maurelian deleted the ci/no-test-nag branch September 29, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants