Skip to content

op-e2e: Action testing L2 Engine Block building#3613

Merged
mslipper merged 2 commits intodevelopfrom
action-l2-engine-building
Sep 30, 2022
Merged

op-e2e: Action testing L2 Engine Block building#3613
mslipper merged 2 commits intodevelopfrom
action-l2-engine-building

Conversation

@protolambda
Copy link
Contributor

Description

This adds block building functionality to the L2 engine actor in action testing.

This will help us write specific test cases where we include certain L2 transactions in specific order, while also running the driver and derivation pipeline (when L2 verifier actor is implemented).

The actual action tests will be less verbose. The testing here is verbose because it tests the implementation of the test utils. If that's tested, we can compose and repeat things.

Depends on #3612

Tests

Test that the L2 engine can build blocks, and that we can instrument the tx inclusion.

Metadata

Fix ENG-2850

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

⚠️ No Changeset found

Latest commit: 947b637

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 29, 2022
@protolambda protolambda force-pushed the action-l2-engine-building branch from 1b5b5a2 to ae485a3 Compare September 29, 2022 16:27
@mergify mergify bot removed the conflict label Sep 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2022

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 30, 2022
@protolambda protolambda force-pushed the action-l2-engine-building branch from f8e9469 to 14c0229 Compare September 30, 2022 19:51
@mergify mergify bot removed the conflict label Sep 30, 2022
@protolambda
Copy link
Contributor Author

Rebased to clean up the diff. The target branch is another PR (#3612) which is about ready. We should merge that first (can use mergify there). I'll then rebase this once more, and then mergify can pick this one up after I remove the label.

Base automatically changed from action-l2-engine to develop September 30, 2022 21:50
@mslipper mslipper merged commit 14591ed into develop Sep 30, 2022
@mslipper mslipper deleted the action-l2-engine-building branch September 30, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants