Skip to content

contracts-bedrock: cleanup imports, fix storage layout#3590

Merged
mergify[bot] merged 6 commits intodevelopfrom
ctb/cleanup-imports
Oct 5, 2022
Merged

contracts-bedrock: cleanup imports, fix storage layout#3590
mergify[bot] merged 6 commits intodevelopfrom
ctb/cleanup-imports

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Sep 28, 2022

Description

We don't need to use the upgradable initializable in the OptimismPortal, also fix the sizes of the storage layout spacers so that they are in sets of 50

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

⚠️ No Changeset found

Latest commit: 50ea64f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Sep 28, 2022
@tynes
Copy link
Contributor Author

tynes commented Sep 29, 2022

Looking for review @maurelian @smartcontracts

@tynes
Copy link
Contributor Author

tynes commented Oct 4, 2022

This needs a rebase

@tynes tynes force-pushed the ctb/cleanup-imports branch from ab35783 to 1383ffa Compare October 4, 2022 20:20
@tynes
Copy link
Contributor Author

tynes commented Oct 4, 2022

I've rebased this, can i get a review @smartcontracts ?

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit d47369f into develop Oct 5, 2022
@mergify mergify bot deleted the ctb/cleanup-imports branch October 5, 2022 17:27
@mergify mergify bot removed the on-merge-train label Oct 5, 2022
This was referenced Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants