Skip to content

e2eutils: collect addresses from test setup for easy fuzzing/test usage#3587

Merged
mergify[bot] merged 2 commits intodevelopfrom
addresses-utils
Sep 29, 2022
Merged

e2eutils: collect addresses from test setup for easy fuzzing/test usage#3587
mergify[bot] merged 2 commits intodevelopfrom
addresses-utils

Conversation

@protolambda
Copy link
Contributor

Description

Simple function to get all addresses involved in the test setup, including their L1/L2 aliases, so we can use those for fuzzing.

Tests

Test that the function works and outputs at least one expected address.

Additional context

Working on fuzz testing as part of action-testing.

Metadata

Fix ENG-2837

Draft PR, depends on action tests setup

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

⚠️ No Changeset found

Latest commit: 0b26090

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

Base automatically changed from action-tests-setup to develop September 28, 2022 16:18
@protolambda protolambda marked this pull request as ready for review September 28, 2022 16:37
@protolambda protolambda requested a review from tynes September 28, 2022 16:37
@protolambda
Copy link
Contributor Author

Hmm, squash merging of the base PR caused this to need a rebase. So we can't really stack small PRs nicely without breaking line count. cc @mslipper

@mslipper
Copy link
Contributor

I'll update the Mergify rules.

@trianglesphere trianglesphere self-requested a review September 28, 2022 22:55
@protolambda
Copy link
Contributor Author

rebased on develop, and using the new non-pointer alias functions now

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 80993f5 into develop Sep 29, 2022
@mergify mergify bot deleted the addresses-utils branch September 29, 2022 19:36
@mergify mergify bot removed the on-merge-train label Sep 29, 2022
This was referenced Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants