Skip to content

Feat: --rpc.evmtimeout#3579

Merged
mslipper merged 4 commits intoethereum-optimism:developfrom
jhawk28:feat/rpc_evmtimeout
Oct 4, 2022
Merged

Feat: --rpc.evmtimeout#3579
mslipper merged 4 commits intoethereum-optimism:developfrom
jhawk28:feat/rpc_evmtimeout

Conversation

@jhawk28
Copy link
Contributor

@jhawk28 jhawk28 commented Sep 27, 2022

Description

Add the ability to set the timeout for eth_call. Was set to only 5 seconds

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

🦋 Changeset detected

Latest commit: b718cf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@github-actions github-actions bot added 2-reviewers C-protocol-critical Category: Modifies protocol-critical code A-cannon Area: cannon labels Sep 27, 2022
@mergify mergify bot requested a review from tynes September 27, 2022 16:44
@jhawk28 jhawk28 force-pushed the feat/rpc_evmtimeout branch from dca1e70 to edf6b30 Compare September 27, 2022 16:50
@tynes
Copy link
Contributor

tynes commented Sep 27, 2022

There is a lot of unnecessary diff in this PR like changing around the ordering of imports. Can you please remove all diffs besides the bare minimum?

@jhawk28 jhawk28 force-pushed the feat/rpc_evmtimeout branch 2 times, most recently from 8a65fdc to 4144fd3 Compare September 27, 2022 17:38
@tynes
Copy link
Contributor

tynes commented Sep 27, 2022

Can you add a changeset? yarn changeset at the root of the repo and then select l2geth and commit the changeset afterwards

@jhawk28 jhawk28 force-pushed the feat/rpc_evmtimeout branch 3 times, most recently from 03e55a5 to 4013243 Compare September 27, 2022 18:59
@tynes
Copy link
Contributor

tynes commented Sep 28, 2022

I think this PR is good, tagging @protolambda for a double check

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doc comments about the 0 == infinite case would be good, LGTM otherwise.

@jhawk28 jhawk28 force-pushed the feat/rpc_evmtimeout branch 2 times, most recently from e4df99a to 25881fa Compare September 28, 2022 16:52
@tynes
Copy link
Contributor

tynes commented Sep 29, 2022

One more thing and I can merge this, sorry I should have mentioned earlier but do you mind changing the changeset to be a patch release?

'@eth-optimism/l2geth': minor

Should be:

'@eth-optimism/l2geth': patch

@jhawk28 jhawk28 force-pushed the feat/rpc_evmtimeout branch from 25881fa to d01484f Compare September 29, 2022 19:30
@tynes
Copy link
Contributor

tynes commented Oct 3, 2022

Thank you @jhawk28 !

@mslipper
Copy link
Contributor

mslipper commented Oct 3, 2022

Pushing this up so CI tests can run.

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2022

This PR has been added to the merge queue, and will be merged soon.

@tynes
Copy link
Contributor

tynes commented Oct 3, 2022

Will need to trigger a release after this merges, cc @mslipper

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mslipper
Copy link
Contributor

mslipper commented Oct 4, 2022

I'll merge this one at the end of the current merge queue - CircleCI does not pass secrets to external forks.

@mslipper mslipper merged commit 89f1abf into ethereum-optimism:develop Oct 4, 2022
This was referenced Oct 13, 2022
@jhawk28 jhawk28 deleted the feat/rpc_evmtimeout branch January 21, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cannon Area: cannon C-protocol-critical Category: Modifies protocol-critical code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants