Feat: --rpc.evmtimeout#3579
Conversation
🦋 Changeset detectedLatest commit: b718cf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
dca1e70 to
edf6b30
Compare
|
There is a lot of unnecessary diff in this PR like changing around the ordering of imports. Can you please remove all diffs besides the bare minimum? |
8a65fdc to
4144fd3
Compare
|
Can you add a changeset? |
03e55a5 to
4013243
Compare
|
I think this PR is good, tagging @protolambda for a double check |
protolambda
left a comment
There was a problem hiding this comment.
Some doc comments about the 0 == infinite case would be good, LGTM otherwise.
e4df99a to
25881fa
Compare
|
One more thing and I can merge this, sorry I should have mentioned earlier but do you mind changing the changeset to be a patch release? Should be: |
25881fa to
d01484f
Compare
|
Thank you @jhawk28 ! |
|
Pushing this up so CI tests can run. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
Will need to trigger a release after this merges, cc @mslipper |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
|
I'll merge this one at the end of the current merge queue - CircleCI does not pass secrets to external forks. |
Description
Add the ability to set the timeout for eth_call. Was set to only 5 seconds
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata