Conversation
Implement encoding and hashing of `CrossDomainMessage` structs. This includes some tests for both v0 and v1 that were generated using solidity. This is required for the migration of withdrawal hashes.
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
maurelian
reviewed
Sep 14, 2022
maurelian
approved these changes
Sep 14, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement encoding and hashing of
CrossDomainMessagestructs. This includes some tests for both v0 and v1 that were generated using solidity.This is required for the migration of withdrawal hashes.