feat(core): use ethers submodules#3363
Merged
mergify[bot] merged 2 commits intodevelopfrom Sep 9, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 749c2d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MetaMask requested that we use ethers submodules instead of importing the entire ethers package. Relatively straightforward change.
smartcontracts
force-pushed
the
sc/core-ethers-subs
branch
from
6d25263 to
963ef24
Compare
6 tasks
tynes
approved these changes
Sep 9, 2022
maurelian
approved these changes
Sep 9, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
MetaMask requested that we use ethers submodules instead of importing the entire ethers package. Relatively straightforward change. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
MetaMask requested that we use ethers submodules instead of importing the entire ethers package. Relatively straightforward change. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MetaMask requested that we use ethers submodules instead of importing the entire ethers package. Relatively straightforward change.
Tests
No test changes are required, no logic is changing.