Skip to content

fix: fix hardhat-node job of release workflow#3353

Closed
shidaxi wants to merge 2 commits intoethereum-optimism:developfrom
shidaxi:patch-1
Closed

fix: fix hardhat-node job of release workflow#3353
shidaxi wants to merge 2 commits intoethereum-optimism:developfrom
shidaxi:patch-1

Conversation

@shidaxi
Copy link

@shidaxi shidaxi commented Sep 8, 2022

Description

fix hardhat-node job of release workflow

Tests

simple error. no need tests

Additional context

Metadata

  • Fixes #[Link to Issue]

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

⚠️ No Changeset found

Latest commit: 3b3eb29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes
Copy link
Contributor

tynes commented Sep 8, 2022

Thanks for this fix. We don't use the hardhat node docker image anymore but nonetheless useful to fix

@smartcontracts
Copy link
Contributor

Hello! Thanks for the PR. I made a similar PR recently which also replaces this image in a few places: #3339

@shidaxi
Copy link
Author

shidaxi commented Sep 9, 2022

OK cool. Let me close this pr

@shidaxi shidaxi closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants