Skip to content

op-chain-ops: MergeStorage deterministic storage results order#3352

Merged
mergify[bot] merged 2 commits intodevelopfrom
chainops-test-storage-order-fix
Sep 8, 2022
Merged

op-chain-ops: MergeStorage deterministic storage results order#3352
mergify[bot] merged 2 commits intodevelopfrom
chainops-test-storage-order-fix

Conversation

@protolambda
Copy link
Contributor

Fixes flaky CI, the random map iteration order resulted in non-deterministic results previously.

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

⚠️ No Changeset found

Latest commit: 07f5d70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit c3cbd74 into develop Sep 8, 2022
@mergify mergify bot deleted the chainops-test-storage-order-fix branch September 8, 2022 14:05
@mergify mergify bot removed the on-merge-train label Sep 8, 2022
maurelian pushed a commit that referenced this pull request Sep 15, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants