op-node: buffer unsafe payloads with priority queue [bedrock]#3346
Merged
op-node: buffer unsafe payloads with priority queue [bedrock]#3346
Conversation
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
…r to maintain max size, and do not drop if the first payload is in the future
protolambda
force-pushed
the
p2p-payloads-buffer
branch
from
c497464 to
246fb0e
Compare
|
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
mslipper
reviewed
Sep 7, 2022
| SequencingErrors: NewEventMetrics(registry, ns, "sequencing_errors", "sequencing errors"), | ||
| PublishingErrors: NewEventMetrics(registry, ns, "publishing_errors", "p2p publishing errors"), | ||
|
|
||
| UnsafePayloadsBufferLen: promauto.With(registry).NewGauge(prometheus.GaugeOpts{ |
mslipper
approved these changes
Sep 7, 2022
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-node: buffer unsafe payloads with priority queue, pop lowest number to maintain max size, and do not drop if the first payload is in the future * payload queue testing * op-node: payload queue metrics, error handling * op-node: fix payloads queue test missing pop * op-node: payloads queue false semgrep case Co-authored-by: Matthew Slipper <me@matthewslipper.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-node: buffer unsafe payloads with priority queue, pop lowest number to maintain max size, and do not drop if the first payload is in the future * payload queue testing * op-node: payload queue metrics, error handling * op-node: fix payloads queue test missing pop * op-node: payloads queue false semgrep case Co-authored-by: Matthew Slipper <me@matthewslipper.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pop blocks by lowest number to maintain max size, and do not drop if the first payload is in the future.
This way we keep the buffer around until block derivation from L1 makes progress, and the unsafe payloads can be processed (or dropped if they do not connect with parent hash).
This should enabled nodes to stay on the canonical unsafe L2 chain, the blocks by the sequencer ahead of what's submitted to L1, more reliably.
Testing work in progress.
Metadata
Fix ENG-2511