fix(ctp): use correct contract import paths#3340
Merged
mergify[bot] merged 2 commits intodevelopfrom Sep 9, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 507044e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fixes two contracts in contracts-periphery to use the correct import paths. Also modifies the contracts package to copy contracts into the root directory on every build, not just before publish. This resolves the issue where the contracts package could not be properly used within the monorepo.
smartcontracts
force-pushed
the
sc/ctp-fix-imports
branch
from
bdce068 to
699ce95
Compare
maurelian
approved these changes
Sep 8, 2022
tynes
approved these changes
Sep 9, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
Fixes two contracts in contracts-periphery to use the correct import paths. Also modifies the contracts package to copy contracts into the root directory on every build, not just before publish. This resolves the issue where the contracts package could not be properly used within the monorepo. Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
Fixes two contracts in contracts-periphery to use the correct import paths. Also modifies the contracts package to copy contracts into the root directory on every build, not just before publish. This resolves the issue where the contracts package could not be properly used within the monorepo. Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two contracts in contracts-periphery to use the correct import
paths. Also modifies the contracts package to copy contracts into the
root directory on every build, not just before publish. This resolves
the issue where the contracts package could not be properly used within
the monorepo.
Fixes #3331
Fixes #850