Skip to content

style(batch-submitter,bss-core,proxyd): Fix lint Go#3328

Merged
mslipper merged 3 commits intodevelopfrom
fix-lint-go
Aug 27, 2022
Merged

style(batch-submitter,bss-core,proxyd): Fix lint Go#3328
mslipper merged 3 commits intodevelopfrom
fix-lint-go

Conversation

@protolambda
Copy link
Contributor

  • Go 1.19 introduced some doc markdown formatting, linter picked that up
  • Go 1.16 moved away from ioutil by making ioutil call the io and os packages under the hood, moving the implementation. It's finally time to fix this now that the linter complains.

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2022

⚠️ No Changeset found

Latest commit: 3842c3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@protolambda protolambda requested a review from mslipper August 27, 2022 01:28
@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper merged commit 61e353e into develop Aug 27, 2022
@mslipper mslipper deleted the fix-lint-go branch August 27, 2022 01:39
maurelian pushed a commit that referenced this pull request Sep 15, 2022
* style(batch-submitter): fix lint

* style(bss-core): fix lint

* chore(proxyd): use io and os instead of deprecated ioutil methods, fixes lint
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
* style(batch-submitter): fix lint

* style(bss-core): fix lint

* chore(proxyd): use io and os instead of deprecated ioutil methods, fixes lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants