op-node: poll for L1 safe and finalized data changes, deduplicate L2 head data#3310
Merged
op-node: poll for L1 safe and finalized data changes, deduplicate L2 head data#3310
Conversation
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
69bcde2 to
b1242b1
Compare
mslipper
approved these changes
Aug 26, 2022
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-term I hope we get safe-head and finalized-head event subscriptions like we have for the chain head. But polling will have to do for now. Should be easy to swap out though, it follows the same subscription / event handling pattern as the L1 head changes.
Metadata
This PR is a prerequisite of #3232 to get the necessary L1 signals.
The polling util may also be useful if we want to use it as a backup mechanism when the L1 heads subscription doesn't work (i.e. when not using websockets). I'll add a note to the L1 head updates reliability issue.