op-node: split l1 source into eth and l1 client#3288
Merged
mergify[bot] merged 4 commits intodevelopfrom Aug 23, 2022
Merged
Conversation
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
Co-authored-by: Javed Khan <javed@optimism.io>
tynes
reviewed
Aug 23, 2022
tynes
reviewed
Aug 23, 2022
tynes
reviewed
Aug 23, 2022
tynes
approved these changes
Aug 23, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-node: split l1 source into eth and l1 client * op-node: fix comment typo Co-authored-by: Javed Khan <javed@optimism.io> * op-node: implement l1 rpc review suggestions Co-authored-by: Javed Khan <javed@optimism.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-node: split l1 source into eth and l1 client * op-node: fix comment typo Co-authored-by: Javed Khan <javed@optimism.io> * op-node: implement l1 rpc review suggestions Co-authored-by: Javed Khan <javed@optimism.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of refactoring the L2 RPC, this splits the L1 RPC source functionality into a more general eth client, and a L1 client that wraps it.
Changes
sourcespackageAccountResulttoethpackage so it can be shared/used everywhereComputeL2OutputRoottorolluppackage so it can be used without importing a RPC bindings packageL1Infoto more generalBlockInfo, and add coinbase header fieldFetchAllTransactionsfrom L1 source bindings (unused for a long time now)BlockToBatchComparison
Old RPC structure.
New RPC structure