Skip to content

op-node: split l1 source into eth and l1 client#3288

Merged
mergify[bot] merged 4 commits intodevelopfrom
eth-rpc-refactor
Aug 23, 2022
Merged

op-node: split l1 source into eth and l1 client#3288
mergify[bot] merged 4 commits intodevelopfrom
eth-rpc-refactor

Conversation

@protolambda
Copy link
Copy Markdown
Contributor

@protolambda protolambda commented Aug 22, 2022

In preparation of refactoring the L2 RPC, this splits the L1 RPC source functionality into a more general eth client, and a L1 client that wraps it.

Changes

  • Move L1 source into sources package
  • Split L1 source into eth client (to be shared with L2 client code) and L1 client (adds the L1 specific client methods)
  • Move AccountResult to eth package so it can be shared/used everywhere
  • Move ComputeL2OutputRoot to rollup package so it can be used without importing a RPC bindings package
  • Change L1Info to more general BlockInfo, and add coinbase header field
  • Remove FetchAllTransactions from L1 source bindings (unused for a long time now)
  • Cleanup Eth client testing a bit (used to be L1 client test)
  • Mirror client bindings structure in mock test utils
  • Remove unused BlockToBatch

Comparison

Old RPC structure.

rpc_old

New RPC structure

rpc_new

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 22, 2022

⚠️ No Changeset found

Latest commit: f35400a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

Copy link
Copy Markdown
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

protolambda and others added 2 commits August 23, 2022 01:58
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 23, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 23, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 696bcc7 into develop Aug 23, 2022
@mergify mergify bot deleted the eth-rpc-refactor branch August 23, 2022 00:34
@mergify mergify bot removed the on-merge-train label Aug 23, 2022
maurelian pushed a commit that referenced this pull request Sep 15, 2022
* op-node: split l1 source into eth and l1 client

* op-node: fix comment typo

Co-authored-by: Javed Khan <javed@optimism.io>

* op-node: implement l1 rpc review suggestions

Co-authored-by: Javed Khan <javed@optimism.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
* op-node: split l1 source into eth and l1 client

* op-node: fix comment typo

Co-authored-by: Javed Khan <javed@optimism.io>

* op-node: implement l1 rpc review suggestions

Co-authored-by: Javed Khan <javed@optimism.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants