Merged
Conversation
I forgot to initialize the forceReset channel which means that the RPC isn't able to signal to the state loop that it needs to reset.
|
trianglesphere
requested review from
mslipper and
protolambda
and removed request for
protolambda
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
approved these changes
Aug 18, 2022
protolambda
approved these changes
Aug 18, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
roninjin10
pushed a commit
that referenced
this pull request
Aug 26, 2022
I forgot to initialize the forceReset channel which means that the RPC isn't able to signal to the state loop that it needs to reset. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
I forgot to initialize the forceReset channel which means that the RPC isn't able to signal to the state loop that it needs to reset. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
I forgot to initialize the forceReset channel which means that the RPC isn't able to signal to the state loop that it needs to reset. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
…nsitions (op-rs/kona#3253) Closes: #3248 This formalizes in a single place logic that was implied by a number of booleans and logic in various parts of DerivationActor. Note: if this state machine is implemented incorrectly, it will cause kona-node to fail at runtime. That said, I can confirm that the following tests have passed: - `just test-e2e-sysgo node node/reorgs large-kona-sequencer` - `just test-e2e-sysgo node node/restart large-kona-sequencer` - `just test-e2e-sysgo node node/common large-kona-sequencer` - `just acceptance-tests kona-node op-reth`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I forgot to initialize the forceReset channel which means that the
RPC isn't able to signal to the state loop that it needs to reset.