Skip to content

Comments

op-node: Add comments to pipeline stages#3213

Merged
mergify[bot] merged 2 commits intodevelopfrom
jg/comments
Aug 12, 2022
Merged

op-node: Add comments to pipeline stages#3213
mergify[bot] merged 2 commits intodevelopfrom
jg/comments

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Aug 12, 2022

Description
This explains each stage in a bit better detail.

@trianglesphere
op-node: Add comments to pipeline stages
4f1bab9 
This explains each stage in a bit better detail.
@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8d6daca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

tuxcanfly
tuxcanfly reviewed Aug 12, 2022
View reviewed changes
tuxcanfly
tuxcanfly approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@trianglesphere @tuxcanfly
Update op-node/rollup/derive/attributes_queue.go
8d6daca 
Co-authored-by: Javed Khan <javed@optimism.io>
protolambda
protolambda approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe move the comments to be a doc-comment of the respective stage struct, instead of the top of the file. Either way is fine.

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 46bfb3c into develop Aug 12, 2022
@mergify mergify bot deleted the jg/comments branch August 12, 2022 22:57
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Aug 12, 2022
roninjin10 pushed a commit that referenced this pull request Aug 26, 2022
@trianglesphere @tuxcanfly
op-node: Add comments to pipeline stages (#3213)
839de51 
* op-node: Add comments to pipeline stages

This explains each stage in a bit better detail.

* Update op-node/rollup/derive/attributes_queue.go

Co-authored-by: Javed Khan <javed@optimism.io>

Co-authored-by: Javed Khan <javed@optimism.io>
maurelian pushed a commit that referenced this pull request Sep 15, 2022
@trianglesphere @tuxcanfly @maurelian
op-node: Add comments to pipeline stages (#3213)
6ec2e99 
* op-node: Add comments to pipeline stages

This explains each stage in a bit better detail.

* Update op-node/rollup/derive/attributes_queue.go

Co-authored-by: Javed Khan <javed@optimism.io>

Co-authored-by: Javed Khan <javed@optimism.io>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
@trianglesphere @tuxcanfly @sam-goldman
op-node: Add comments to pipeline stages (#3213)
4cd3c45 
* op-node: Add comments to pipeline stages

This explains each stage in a bit better detail.

* Update op-node/rollup/derive/attributes_queue.go

Co-authored-by: Javed Khan <javed@optimism.io>

Co-authored-by: Javed Khan <javed@optimism.io>
theochap pushed a commit that referenced this pull request Jan 15, 2026
@op-will
cleanup(node/actor): Consolidate DerivationActor inbound channels (op…
49881c3 
…-rs/kona#3229)

See: #3223 

This also reworks aspects of `EngineActor`. See referenced issues.

closes #3223, #3213, #3215, #3216, #3219, and #3072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mslipper mslipper Awaiting requested review from mslipper

2 more reviewers

@tuxcanfly tuxcanfly tuxcanfly approved these changes

@protolambda protolambda protolambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trianglesphere @tuxcanfly @protolambda