op-node: reorgs should be typed to force pipeline resets [bedrock]#3185
Merged
op-node: reorgs should be typed to force pipeline resets [bedrock]#3185
Conversation
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
approved these changes
Aug 6, 2022
roninjin10
pushed a commit
that referenced
this pull request
Aug 26, 2022
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed these important reorg errors in #3130 which caused reorgs to be handled like temporary errors, and not result in a reset of the derivation pipeline, and thus never getting unstuck after a L1 reorg.