Conversation
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
Adds support for the following batch derivation metrics: - 0/1 gauge for if the derivation is idle - Count of total pipeline resets - Count of total unsafe payloads received - Count of total derivation errors - Gauge tracking the various L1/L2 safe/unsafe heads
35bb2f4 to
18d9bff
Compare
protolambda
reviewed
Aug 2, 2022
Contributor
protolambda
left a comment
There was a problem hiding this comment.
Nice work! Some nits on application of metrics in driver event loop, then good to merge.
protolambda
approved these changes
Aug 2, 2022
Merged
roninjin10
pushed a commit
that referenced
this pull request
Aug 26, 2022
* op-node: Derivation metrics Adds support for the following batch derivation metrics: - 0/1 gauge for if the derivation is idle - Count of total pipeline resets - Count of total unsafe payloads received - Count of total derivation errors - Gauge tracking the various L1/L2 safe/unsafe heads * review updates + more metrics
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-node: Derivation metrics Adds support for the following batch derivation metrics: - 0/1 gauge for if the derivation is idle - Count of total pipeline resets - Count of total unsafe payloads received - Count of total derivation errors - Gauge tracking the various L1/L2 safe/unsafe heads * review updates + more metrics
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-node: Derivation metrics Adds support for the following batch derivation metrics: - 0/1 gauge for if the derivation is idle - Count of total pipeline resets - Count of total unsafe payloads received - Count of total derivation errors - Gauge tracking the various L1/L2 safe/unsafe heads * review updates + more metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the following batch derivation metrics: