op-proposer, op-batcher: Support private keys in addition to mnemonics

[mslipper]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0befcf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mergify]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

[tynes]

I think @protolambda wanted to move to using encrypted keystores
https://github.com/ethereum/go-ethereum/blob/a0b88ce869d6be243c6b1900d69b9401f2d2c092/cmd/ethkey/generate.go#L109
https://github.com/ethereum/go-ethereum/blob/a0b88ce869d6be243c6b1900d69b9401f2d2c092/accounts/keystore/key.go#L66

I think this is fine because it won't require any changes in tooling or the way we handle secrets

[protolambda]

Maybe ideally we define one go module that can support the loading of private keys, in various ways:

• mnemonic + path
• private key
• encrypted keystore + password

That way we don't duplicate security-critical code, make it easy to audit, and easy to use.

Also ideally with discouraged use of mnemonic and private key. And warnings if you put the mnemonic, private key, or password in CLI instead of env var. (Since shell history / log streaming may log the CLI command and leak it)

I've been thinking we should have an op-service go module, for exactly this type of thing. As well as logging configuration, metrics, and pprof.

I'm fine with merging this PR as-is, but it would be nice if we can refactor it all into a common op-service module later.

[mslipper]

I agree with the op-service module. We have a lot of duplication among our various Go projects and it would be great to clean it up. We'll also need a separate "Signer" function to support things like Cloud HSMs in prod.

I'll merge this as-is, but will ticket the op-service work so we can get started on it.