op-node: Properly set timestamp in PreparePayloadAttributes#3151
op-node: Properly set timestamp in PreparePayloadAttributes#3151mergify[bot] merged 2 commits intodevelopfrom
Conversation
This now uses a passed in timestamp for PreparePayloadAttributes. This is important because when generating a payload attributes from a batch it should be using the timestamp of the batch, not the L2 parent + block time. When we are creating payloads based on the L2 parent time, that is easy to set there instead of pulling it into this function. This enabled/exacerbated a divergence bug where the timestamp of the batch was not the timestamp that was being set inside PreparePayloadAttributes.
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
|
Merge failed. Please see automated check logs for more details. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This now uses a passed in timestamp for PreparePayloadAttributes. This is important because when generating a payload attributes from a batch it should be using the timestamp of the batch, not the L2 parent + block time. When we are creating payloads based on the L2 parent time, that is easy to set there instead of pulling it into this function. This enabled/exacerbated a divergence bug where the timestamp of the batch was not the timestamp that was being set inside PreparePayloadAttributes. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This now uses a passed in timestamp for PreparePayloadAttributes. This is important because when generating a payload attributes from a batch it should be using the timestamp of the batch, not the L2 parent + block time. When we are creating payloads based on the L2 parent time, that is easy to set there instead of pulling it into this function. This enabled/exacerbated a divergence bug where the timestamp of the batch was not the timestamp that was being set inside PreparePayloadAttributes. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
4 participants
Description
This now uses a passed in timestamp for PreparePayloadAttributes.
This is important because when generating a payload attributes from
a batch it should be using the timestamp of the batch, not the
L2 parent + block time. When we are creating payloads based on the
L2 parent time, that is easy to set there instead of pulling it into
this function.
This enabled/exacerbated a divergence bug where the timestamp of the
batch was not the timestamp that was being set inside
PreparePayloadAttributes.
Metadata