Merged
Conversation
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
force-pushed
the
feat/libp2p-utils
branch
from
dcd3eda to
21146c1
Compare
mslipper
force-pushed
the
feat/libp2p-utils
branch
from
21146c1 to
34a8b3d
Compare
Co-authored-by: Joshua Gutow <jgutow@optimism.io>
Co-authored-by: Joshua Gutow <jgutow@optimism.io>
trianglesphere
approved these changes
Aug 1, 2022
protolambda
reviewed
Aug 1, 2022
protolambda
approved these changes
Aug 1, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
mslipper
added a commit
that referenced
this pull request
Aug 1, 2022
Merged
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-node: Add p2p utils * Update op-node/cmd/p2p/cmd.go Co-authored-by: Joshua Gutow <jgutow@optimism.io> * Update op-node/cmd/p2p/cmd.go Co-authored-by: Joshua Gutow <jgutow@optimism.io> * lint * fix devnet Co-authored-by: Joshua Gutow <jgutow@optimism.io>
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-node: Add p2p utils * Update op-node/cmd/p2p/cmd.go Co-authored-by: Joshua Gutow <jgutow@optimism.io> * Update op-node/cmd/p2p/cmd.go Co-authored-by: Joshua Gutow <jgutow@optimism.io> * lint * fix devnet Co-authored-by: Joshua Gutow <jgutow@optimism.io>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Changes - `crates/node/sources/src/signer/remote/cert.rs`: Use `CertificateDer::pem_file_iter` and `PrivateKeyDer::from_pem_file` instead of `rustls_pemfile` functions - `crates/node/sources/Cargo.toml`: Remove `rustls-pemfile` dependency - `Cargo.toml`: Remove `rustls-pemfile` from workspace dependencies Closes #3149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds utilities for handling P2P keys. Note that to prevent having to specify irrelevant CLI flags, I created a new
startcommand that actually stats the node.