contracts-bedrock: add forge contract verification support#3141
Merged
mergify[bot] merged 2 commits intodevelopfrom Aug 2, 2022
Merged
contracts-bedrock: add forge contract verification support#3141mergify[bot] merged 2 commits intodevelopfrom
mergify[bot] merged 2 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 903d205 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
protolambda
reviewed
Aug 1, 2022
protolambda
approved these changes
Aug 1, 2022
Contributor
|
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
mslipper
approved these changes
Aug 1, 2022
Add etherscan contract verification for the hh/foundry compiler toolchain. This will eventually be upstreamed, but is implemented here to ensure that it works thoroughly first. To run the task: ``` export ETHERSCAN_API_KEY=$(cat api-key.txt) $ npx hardhat forge-verify --network goerli ``` In the future, other contract verification backends will be added to forge and this task will be updated to support them. Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code An individual contract can be targeted instead of all of them with the `--contract` flag. If hardhat deploy has configured external deployments, forge will not be able to verify them. It may be possible to implement that in the future.
tynes
force-pushed
the
feat/forge-etherscan-verify
branch
from
8c1e014 to
903d205
Compare
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
roninjin10
pushed a commit
that referenced
this pull request
Aug 26, 2022
* contracts-bedrock: add forge contract verification support Add etherscan contract verification for the hh/foundry compiler toolchain. This will eventually be upstreamed, but is implemented here to ensure that it works thoroughly first. To run the task: ``` export ETHERSCAN_API_KEY=$(cat api-key.txt) $ npx hardhat forge-verify --network goerli ``` In the future, other contract verification backends will be added to forge and this task will be updated to support them. Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code An individual contract can be targeted instead of all of them with the `--contract` flag. If hardhat deploy has configured external deployments, forge will not be able to verify them. It may be possible to implement that in the future. * contracts-bedrock: modularize tasks
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* contracts-bedrock: add forge contract verification support Add etherscan contract verification for the hh/foundry compiler toolchain. This will eventually be upstreamed, but is implemented here to ensure that it works thoroughly first. To run the task: ``` export ETHERSCAN_API_KEY=$(cat api-key.txt) $ npx hardhat forge-verify --network goerli ``` In the future, other contract verification backends will be added to forge and this task will be updated to support them. Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code An individual contract can be targeted instead of all of them with the `--contract` flag. If hardhat deploy has configured external deployments, forge will not be able to verify them. It may be possible to implement that in the future. * contracts-bedrock: modularize tasks
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* contracts-bedrock: add forge contract verification support Add etherscan contract verification for the hh/foundry compiler toolchain. This will eventually be upstreamed, but is implemented here to ensure that it works thoroughly first. To run the task: ``` export ETHERSCAN_API_KEY=$(cat api-key.txt) $ npx hardhat forge-verify --network goerli ``` In the future, other contract verification backends will be added to forge and this task will be updated to support them. Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code An individual contract can be targeted instead of all of them with the `--contract` flag. If hardhat deploy has configured external deployments, forge will not be able to verify them. It may be possible to implement that in the future. * contracts-bedrock: modularize tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add etherscan contract verification for the hh/foundry
compiler toolchain. This will eventually be upstreamed,
but is implemented here to ensure that it works thoroughly
first.
To run the task:
In the future, other contract verification backends
will be added to forge and this task will be updated
to support them.
Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code
An individual contract can be targeted instead of all of them
with the
--contractflag. If hardhat deploy has configuredexternal deployments, forge will not be able to verify them.
It may be possible to implement that in the future.